pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16164 )
Change subject: msgb_put: more elaborate logging of head/tailroom failure ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/16164/2/include/osmocom/core/msgb.h File include/osmocom/core/msgb.h: https://gerrit.osmocom.org/c/libosmocore/+/16164/2/include/osmocom/core/msgb.h@243 PS2, Line 243: " (allocated %u, head at %u, len %u, tailroom %u < want tailroom %u)\n", isn't msgb->head - msgb->_data a pointer? then use %p instead of %u. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55b68098e1037c74ebe5faa86e34bd4494f5b726 Gerrit-Change-Number: 16164 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2019 14:47:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment