fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13338 )
Change subject: make use of OTC_GLOBAL when allocating library-internal contexts ...................................................................... Patch Set 15: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/13338/15/src/ctrl/control_vty.c File src/ctrl/control_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/15/src/ctrl/control_vty.c@85 PS15, Line 85: ctx Wouldn't GCC warn us that this argument is passed but not used? I really like the approach of Wireshark - the '_U_' macro / attribute. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1 Gerrit-Change-Number: 13338 Gerrit-PatchSet: 15 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 23 Nov 2019 13:56:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment