neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15961 )
Change subject: add osmo_sockaddr_str_cmp() ...................................................................... Patch Set 7: (1 comment) (submitting old comments that I forgot to submit) https://gerrit.osmocom.org/c/libosmocore/+/15961/6/src/sockaddr_str.c File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/15961/6/src/sockaddr_str.c@117 PS6, Line 117: if (cmp) : return cmp; : return 0; > Why this instead of simply "return cmp"? (patch rework artifact, thx) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0dbc1cf707098dcda75f8e07c1b936951f9f9501 Gerrit-Change-Number: 15961 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2019 21:58:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment