Hello laforge, I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16242 to review the following change. Change subject: disable talloc_memlimit() and use existing msgb_context (pool) ...................................................................... disable talloc_memlimit() and use existing msgb_context (pool) Change-Id: I7d3a00ea4581b4f01e72294ac4e810e54c410e24 --- M sysmoOCTSIM/libosmo_emb.c M sysmoOCTSIM/main.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/42/16242/1 diff --git a/sysmoOCTSIM/libosmo_emb.c b/sysmoOCTSIM/libosmo_emb.c index 5209e20..09555f3 100644 --- a/sysmoOCTSIM/libosmo_emb.c +++ b/sysmoOCTSIM/libosmo_emb.c @@ -151,7 +151,7 @@ /* msgb */ g_msgb_ctx = talloc_pool(g_tall_ctx, 20480); - talloc_set_memlimit(g_msgb_ctx, 20480); + //talloc_set_memlimit(g_msgb_ctx, 20480); msgb_talloc_ctx_init(g_msgb_ctx, 0); /* logging */ diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 6815b18..d81f189 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -1171,7 +1171,7 @@ LOGP(DUSB, LOGL_ERROR, "foobar usb\n"); //FIXME osmo_emb has a pool? - msgb_set_talloc_ctx(g_tall_ctx); + //msgb_set_talloc_ctx(g_tall_ctx); //prevent spurious interrupts before our driver structs are ready CRITICAL_SECTION_ENTER() -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I7d3a00ea4581b4f01e72294ac4e810e54c410e24 Gerrit-Change-Number: 16242 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-MessageType: newchange