Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318 )
Change subject: add the talloc ctx to struct ccid_instance ...................................................................... Patch Set 1: > Patch Set 1: > > It's a bit of a question of taste. I would state we typically don't put > talloc contexts in objects that are themselves not talloc-allocated (like > g_ci which is statically allocated). > > Also, having the same talloc context (or really any information) stored twice > seems a bit odd to me. But if you insist, go ahead... There is unfortunately no really pretty way of sharing the global context between host and fw builds, a global variable that is globally accessible is not really better, and now that it is part of the struct the global var can be removed later if it's no necessary for convenient debugging. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3b73e68d0347d74f68018614613fcc802f3fdfe7 Gerrit-Change-Number: 16318 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Fri, 29 Nov 2019 17:34:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
