laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16398 )
Change subject: remsim: Ensure non-overlapping junit-xml filenames ...................................................................... remsim: Ensure non-overlapping junit-xml filenames The default filename pattern of the JUnit log plugins of TTCN-3 is "junit-xml-%u.xml" where %u represents the PID of the process. This is typically a good idea as the PID doesn't wrap that quickly. However, if you're executing a new docker container for every test suite run, then chances are high that two subsequent runs of the test suite container might end up with the same PID and hence the smae filename. This results in the output file being overwritten, which is what's responsible for many missing RemsimServer_Tests results on the jenkins.osmocom.org test results analyzer. Change-Id: I9b6d1b5a943eb4e058ad2bf7cf8acee7b70e68b6 Closes: OS#4205 --- M ttcn3-remsim-test/REMSIM_Tests.cfg M ttcn3-remsim-test/bankd/REMSIM_Tests.cfg M ttcn3-remsim-test/client/REMSIM_Tests.cfg 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/ttcn3-remsim-test/REMSIM_Tests.cfg b/ttcn3-remsim-test/REMSIM_Tests.cfg index 5a9f026..837f12b 100644 --- a/ttcn3-remsim-test/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-server" [TESTPORT_PARAMETERS] diff --git a/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg b/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg index 2e77590..ca83346 100644 --- a/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-bankd" [TESTPORT_PARAMETERS] diff --git a/ttcn3-remsim-test/client/REMSIM_Tests.cfg b/ttcn3-remsim-test/client/REMSIM_Tests.cfg index d3f8d42..2484c73 100644 --- a/ttcn3-remsim-test/client/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/client/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-client" [TESTPORT_PARAMETERS] # IP address to which ATS binds emulated remsim-server -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/16398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9b6d1b5a943eb4e058ad2bf7cf8acee7b70e68b6 Gerrit-Change-Number: 16398 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-MessageType: merged