fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486 )

Change subject: pcu: Fix incorrect FN being send over PCUIF to PCU
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486/1/pcu/PCUIF_RAW_Components.ttcn
File pcu/PCUIF_RAW_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486/1/pcu/PCUIF_RAW_Components.ttcn@315
PS1, Line 315: event.data.tdma_fn - 3
> Why? can you extend your comment please?
Because PTCCH is interleaved over 4 _non-consecutive_ bursts, so you cannot 
just do -4. See  3GPP TS 145.002, or 
https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_mframe.c#n1811.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba0b1d1a3d7d875c5443a7bcaff399f9681624ad
Gerrit-Change-Number: 16486
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Dec 2019 06:14:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <axilira...@gmail.com>
Gerrit-MessageType: comment

Reply via email to