fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16566 )
Change subject: MSC_Tests.ttcn: fix: verify the contents of SM-RP DA/OA for MO SMS ...................................................................... MSC_Tests.ttcn: fix: verify the contents of SM-RP DA/OA for MO SMS Change-Id: Ib467eeca6439bc6cce72293fbb5bb48f6d233db9 --- M msc/MSC_Tests.ttcn 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/16566/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 25d6b64..61b637a 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -2085,10 +2085,17 @@ var template GSUP_PDU mo_forwardSM := tr_GSUP_MO_FORWARD_SM_REQ( imsi := g_pars.imsi, sm_rp_mr := spars.rp.msg_ref, - /* FIXME: extract SM-RP-DA from spars.rp.dest */ - sm_rp_da := tr_GSUP_SM_RP_DA_SMSC_ADDR(?), - /* FIXME: MSISDN coding troubles */ - sm_rp_oa := tr_GSUP_SM_RP_OA_MSISDN(?), + /* SM-RP-DA: SMSC address */ + sm_rp_da := tr_GSUP_SM_RP_DA_SMSC_ADDR(t_GSUP_SM_RP_Addr( + number := spars.rp.dest.rP_NumberDigits, + npi := spars.rp.dest.rP_NumberingPlanIdentification, + ton := spars.rp.dest.rP_TypeOfNumber, + ext := spars.rp.dest.rP_Ext)), + /* SM-RP-OA: subscriber's MSISDN (filled in by MSC) */ + sm_rp_oa := tr_GSUP_SM_RP_OA_MSISDN(t_GSUP_SM_RP_Addr( + number := g_pars.msisdn, + /* FIXME: MSISDN we have in g_pars lacks this info */ + npi := ?, ton := ?, ext := ?)), /* TODO: can we use decmatch here? */ sm_rp_ui := sm_tpdu ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib467eeca6439bc6cce72293fbb5bb48f6d233db9 Gerrit-Change-Number: 16566 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-MessageType: newchange