laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16203 )
Change subject: add osmo-mslookup-client program ...................................................................... Patch Set 21: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hlr/+/16203/19/src/mslookup/osmo-mslookup-client.c File src/mslookup/osmo-mslookup-client.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16203/19/src/mslookup/osmo-mslookup-client.c@61 PS19, Line 61: "\n" it's fairy atypical for us to print such extensive help messages interactively. I don't have a strong opinion, but I would guess a man page is more applicable for this. Instead of writing that manpage from hand, one can actually do this in asciidoc these days (and hopefully the same .adoc could then also be transparently imported into our manuals?) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ie68a5c1db04fb4dff00dc3c774a1162f5b9fabf7 Gerrit-Change-Number: 16203 Gerrit-PatchSet: 21 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2019 17:30:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
