fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16536 )
Change subject: Allow Gb PAGING-PS without P-TMSI ...................................................................... Patch Set 4: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/encoding.cpp@747 PS4, Line 747: bitvec_write_field Can we use bitvec_set_bytes() here? https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/gprs_bssgp_pcu.cpp@21 PS4, Line 21: #include "inttypes.h" Do we really need this include? https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/gprs_bssgp_pcu.cpp@186 PS4, Line 186: BSSGP_CAUSE_COND_IE_ERR Unrelated change, and is it really CONDitional IE? Looks more like mandatory. https://gerrit.osmocom.org/c/osmo-pcu/+/16536/4/src/gprs_bssgp_pcu.cpp@191 PS4, Line 191: TLVP_LEN(tp, BSSGP_IE_IMSI)); Looks like unrelated change. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dbf8db04e81f98352a42ce34a5d91326be9bfd1 Gerrit-Change-Number: 16536 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2020 12:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
