pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/9957 )
Change subject: fix memleaks in mtp_user_prim_cb() ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/9957/3/src/sccp_scoc.c File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/9957/3/src/sccp_scoc.c@1415 PS3, Line 1415: sccp_scrc_rx_scoc_conn_msg(inst, xua); why is this function called _rx_ and not _tx_ ? It's confusing. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/9957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I72b3c6a6f57ba32d9ba191af33b4b236492174e0 Gerrit-Change-Number: 9957 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2020 17:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment