pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16257 )
Change subject: D-GSM 2/n: implement mDNS method of mslookup server ...................................................................... Patch Set 14: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server.h File include/osmocom/hlr/mslookup_server.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server.h@22 PS14, Line 22: #include <osmocom/gsupclient/gsup_peer_id.h> So no change in the header file but 2 new includes are added? That looks wrong... https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server_mdns.h File include/osmocom/hlr/mslookup_server_mdns.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server_mdns.h@22 PS14, Line 22: #include <stdbool.h> bool is not used here, you can drop it. https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c File src/dgsm_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c@177 PS14, Line 177: "service NAME at IP <1-65535>", let's drop that "at" here, I don't see it bringing anything good rather than having to type more. https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c@236 PS14, Line 236: "no service NAME at IP <1-65535>", remove "at". -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5cae6459090588b4dd292be90a5e8903432669d2 Gerrit-Change-Number: 16257 Gerrit-PatchSet: 14 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 08 Jan 2020 13:49:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
