pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16205 )
Change subject: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name ...................................................................... Patch Set 23: 1- I didn't say it was easy, yet is something really desirable. 2- I agree with keeping ipa-name as a null-terminated string. Simply add checks in case it's not upon receiving, but afaik it's not null terminated only on really old code of ours (and maybe nanobts?) which anyway is not being used here, and which was fixed a while ago to be null-terminated. 3- It's not only about reviewing for merge. It's a problem about discussing each change. It's a problem when reading the git log. It's a problem when bisecting. It's a problem when understanding why and how stuff was changed, and the implications it had. It's a problem when reverting. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9 Gerrit-Change-Number: 16205 Gerrit-PatchSet: 23 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jan 2020 14:48:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
