neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 )
Change subject: add mDNS lookup method to libosmo-mslookup ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/c/osmo-hlr/+/16256/11/src/mslookup/mdns_sock.c File src/mslookup/mdns_sock.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16256/11/src/mslookup/mdns_sock.c@129 PS11, Line 129: int osmo_mdns_sock_send(const struct osmo_mdns_sock *mdns_sock, struct msgb *msg) > I think it might be an idea to optionally put this on the wire more than > once, based on a configurat […] as discussed on IRC: On lossy links, it makes sense to re-send N mDNS requests with a delay between them, configurable by cfg file. All that is required is a timer here that re-sends the same msgb N times. All the rest will already work without code changes: Each request reached will cause a separate response, and the requestor will consolidate all received results into one final result. (One could also consider caching responses at the server to optimize resending the same result, but that is likely overkill.) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I03a0ffa1d4dc1b24ac78a5ad0975bca90a49c728 Gerrit-Change-Number: 16256 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: keith <ke...@rhizomatica.org> Gerrit-Comment-Date: Thu, 09 Jan 2020 14:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <ke...@rhizomatica.org> Gerrit-MessageType: comment
