dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16885 )
Change subject: ta_control: move timing advance code from osmo-bts-trx to common ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/c/osmo-bts/+/16885/3/src/common/ta_control.c File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/3/src/common/ta_control.c@52 PS3, Line 52: LOGL_INFO > maybe switch this to DEBUG, as a non-changing TA is the default, and one > might want to see only the […] Done https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/src/osmo-bts-trx/trx_vty.c@196 PS2, Line 196: vty_out (vty, "'no osmotrx timing-advance-loop' is deprecated%s", VTY_NEWLINE); > I'd add some string telling the user that no extra operation is needed, TA > loop will be enabled by d […] Its now active by default. I can make it optional if there are any concerns but in the end its a standard feature of a BTS. https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c File tests/ta_control/ta_control_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@43 PS2, Line 43: for (i=0; i<steps; i++) { > spacing i = 0; i < steps looks like I forgot to run lindent.sh https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@47 PS2, Line 47: > whitespace Done https://gerrit.osmocom.org/c/osmo-bts/+/16885/2/tests/ta_control/ta_control_test.c@55 PS2, Line 55: > whitespace Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If7ddf74db3abc9b9872abe620a0aeebe3327e70a Gerrit-Change-Number: 16885 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2020 10:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
