pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16885 )
Change subject: ta_control: move timing advance code from osmo-bts-trx to common ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/16885/4/src/common/ta_control.c File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/16885/4/src/common/ta_control.c@30 PS4, Line 30: #define TOA256_MAX 63 AFAIU that's not TOA256, but TOA. TOA256_MAX would be 63*256, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If7ddf74db3abc9b9872abe620a0aeebe3327e70a Gerrit-Change-Number: 16885 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2020 12:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
