osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914 )
Change subject: hlr: add TC_MSLookup_mDNS_server ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914/7/library/MSLookup_mDNS_Emulation.ttcn File library/MSLookup_mDNS_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914/7/library/MSLookup_mDNS_Emulation.ttcn@16 PS7, Line 16: /* Transcode between mDNS and UDP: > Fine, but TBH I'm still not understanding why is this required. […] It might be possible that we could omit this file completely, and directly use dec_PDU_DNS and enc_PDU_DNS. I've adapted it from the other library/*_Emulation.ttcn files and from the demo code in titan.ProtocolModules.DNS. But then I'm not sure how we would specify the UDP port... In order to not spend too much time on this, I'd just keep it as-is, unless we have a good reason to refactor it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7f92d33691f910549353b16a7b0efc18e521719 Gerrit-Change-Number: 16914 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2020 13:41:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
