pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17415 )
Change subject: virt_phy: implement GSMTAP_CHANNEL_VOICE ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/17415/3/src/host/virt_phy/src/gsmtapl1_if.c File src/host/virt_phy/src/gsmtapl1_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/17415/3/src/host/virt_phy/src/gsmtapl1_if.c@113 PS3, Line 113: data = msgb_l2(msg); isn't this line unneeded? Aren't you doing "A = B; B = A;" here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id72cf23b7c6587efae4cdaa7b50ab4d85b8c8d22 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 09 Mar 2020 09:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
