laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 )
Change subject: bts: Add RTP payload testing to performance tests ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/2/bts/BTS_Tests.ttcn@538 PS2, Line 538: * the testcase. */ I'm not sure if we want this overrhead of 14 RTPEM (and their downstream components, each of those a forked process) for every test case, even if it doesn't relate to RTP / user plane at all. Maybe make this conditional to a boolean variable in "pars"? Or have an explicit f_init_rtpem() which those tests then have to call "manually"? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/2/bts/RTP_CodecPort_CtrlFunct.ttcn File bts/RTP_CodecPort_CtrlFunct.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/2/bts/RTP_CodecPort_CtrlFunct.ttcn@1 PS2, Line 1: module RTP_CodecPort_CtrlFunct { > Isn't this generic enough to be put under lib/? I agree, the RTP_CodecPort related files should be under lib/ and linked in with gen_links.sh. Right now I'm wondering if they are actually used? IT looks to me as if only the RTP Emulation is used? I cannot find any reference to RTP_CODEC_PT outside of this file, for example... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21a610533d5be2e1647cc6a72423e056b39d1217 Gerrit-Change-Number: 17285 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 09 Mar 2020 17:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
