pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 )
Change subject: process: add stdin_write method to communicate with child on stdin ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560/1/src/osmo_gsm_tester/process.py File src/osmo_gsm_tester/process.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560/1/src/osmo_gsm_tester/process.py@358 PS1, Line 358: self.process_obj.communicate(input="{}".format(cmd).encode("utf-8"), timeout=5) afair the timeout is to verify the process exits after sending the data through stdin, are you sure that's what you want here? https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560/1/src/osmo_gsm_tester/process.py@360 PS1, Line 360: self.log('Timeout expired while writing to stdout') You mean while writing to stdin -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre <an...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 21 Mar 2020 23:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
