pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 )
Change subject: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging. ...................................................................... Patch Set 3: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c File src/utils/meas_json.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@176 PS3, Line 176: .name = "MEAS_JSON", I think we never user underscores or alike in names (I may be wrong tough). You can simply call it MAIN. Is this category actually used? why does it have index 0 with no define? is there any LOGP(0, ...)? https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@178 PS3, Line 178: .loglevel = LOGL_DEBUG, debug doesn't sound like a good default. Probably bettee using NOTICE here. https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@191 PS3, Line 191: log_init(&log_info, NULL); where does this functon come from? It should be osmo_init_logging2(tall_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278 Gerrit-Change-Number: 17647 Gerrit-PatchSet: 3 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sat, 28 Mar 2020 17:31:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
