laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17758 )
Change subject: sgsnemu: Refactor arg/cfg parser to use talloc ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/17758/2/sgsnemu/cmdline.c File sgsnemu/cmdline.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/17758/2/sgsnemu/cmdline.c@2 PS2, Line 2: File autogenerated by gengetopt version 2.22.6 : generated with the following command: you are aware that you are modifing a file that's generated code? If you really want to go there, you should provide some kind of sed or 'spatch' script that one can execute after re-generating cmdline.c using gengetopt. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ie0d48a12a8349be5a859a03191421cbd9cc324cc Gerrit-Change-Number: 17758 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 11 Apr 2020 09:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
