herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17879 )
Change subject: Enable parsing of USIM Service table (UST) ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/pysim/+/17879/6/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/17879/6/pySim-read.py@264 PS6, Line 264: if s in EF_UST_map > We may also want to print those which are not in EF_UST_map: […] how about printing "Available" and "Not Available" for each service number? https://gerrit.osmocom.org/c/pysim/+/17879/6/pySim-read.py@265 PS6, Line 265: s in avail_srvs > Does this really make sense? Since we do 'for s in avail_srvs', it will > always be True... True. It doesnt make sense as it will always be true. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54dbbd40bd3d22cee81f7c32e58cd946f8564257 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 6 Gerrit-Owner: herlesupreeth <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: herlesupreeth <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 20 Apr 2020 10:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
