pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16459 )
Change subject: 2/2: fixup: add osmo_gsup_peer_id with type enum and union ...................................................................... Patch Set 9: Regarding your last recap, I'd say I only have 2 main requirements: * Whatever new peer_id struct you add in libgsupclient, since it's going to be expanded / made more complex in the future (due to adding more id types like global title), make it opaque to the public API and provide public APIs to retrieve content from it, so we don't have to break ABI compatibility later on. I'm fine with whatever you decide for now to use internally as long as looks reasonable clean (with low standards even as long as it's internal). * Clean it up with regard to the previous patch (squash them and split them again if needed) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5 Gerrit-Change-Number: 16459 Gerrit-PatchSet: 9 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 28 Apr 2020 17:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
