fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187 )
Change subject: PCU: introduce a new test case TC_dl_flow_more_blocks ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn@1644 PS1, Line 1644: ack_nack_desc.receive_block_bitmap[63] := '1'B; > No use of f_acknackdesc_ack_block() here? ACK, thanks! https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn@1679 PS1, Line 1679: // f_rx_rlcmac_dl_block(dl_block, fn); > a data block? good question. I think I figured it out. This happens if Packet Downlink Ack/Nack we're sending has final_ack bit set to '0'B. The MS determines whether to set this bit by looking at FBI [1] of the last block received within the current RRBP. The problem is that in this scenario the SGSN sends blocks not all at once, but during the whole RRBP period, so the PCU cannot know in advance which block is the last one. [1] Final Block Indication, not Federal Bureau of Investigation ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I45edbc943194c15b084eb04dda390db75b4bfa0f Gerrit-Change-Number: 18187 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 11 May 2020 06:43:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
