neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 )
Change subject: stats: Add counters and gauges for BORKEN lchans/TS ...................................................................... Patch Set 3: Code-Review-1 (1 comment) I regret keeping the misspelled "borken" in the FSMs, maybe the exported stats could say "broken" instead? (OTOH fine with me if the spelling should match the logs.) But let's definitely not introduce yet another misspelling as in this patch (s.b.) https://gerrit.osmocom.org/c/osmo-bsc/+/18192/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18192/3/include/osmocom/bsc/gsm_data.h@1520 PS3, Line 1520: BTS_STAT_TS_BORKED, let's not introduce another variation of "broken" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I427bbe1613a0e92bff432a7d76592fe50f620ebe Gerrit-Change-Number: 18192 Gerrit-PatchSet: 3 Gerrit-Owner: ipse <alexander.cheme...@gmail.com> Gerrit-Assignee: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <alexander.cheme...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 May 2020 12:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
