pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18133 )
Change subject: Expect ms object to exist before calling tbf_alloc_ul_tbf() ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+2 > > (1 comment) > > I am wondering if it's possible to avoid these formal (dummy) MS allocations > and make it legal for a TBF to exist without being associated to particular > MS instance until it's know to whom it belongs to. No way! Let's please skip this model where objects can have or not associations to other objects. A TBF is ALWAYS associated to an MS even if we lack some information about that MS. Let's always have an objet and let the object handle all the state on what information we have about it instead of trying to figure out in all different places. If a TBF is to be created, it has to be created from an MS. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I010aa5877902816ae246e09ad5ad87946f96855c Gerrit-Change-Number: 18133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 May 2020 16:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
