laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18205
)
Change subject: cards: remove len calculation
......................................................................
cards: remove len calculation
The method update_ad() caluclates the size of the data it had just
read from EF.AD, but the result is never used, lets remove that
line
Change-Id: Id38c0dc725ab6874de3ea60132482a09372abe9e
---
M pySim/cards.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
fixeria: Looks good to me, approved
diff --git a/pySim/cards.py b/pySim/cards.py
index 8937ee8..f469cae 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -149,7 +149,6 @@
raise RuntimeError('unable to calculate proper mnclen')
data = self._scc.read_binary(EF['AD'], length=None, offset=0)
- size = len(data[0]) // 2
content = data[0][0:6] + "%02X" % mnclen
data, sw = self._scc.update_binary(EF['AD'], content)
return sw
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/18205
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id38c0dc725ab6874de3ea60132482a09372abe9e
Gerrit-Change-Number: 18205
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged
