laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17931 )
Change subject: gsm0505_amr_dtx: add missing value strings ...................................................................... gsm0505_amr_dtx: add missing value strings The value string array that explain the type of the AMR DTX / SID frames is incomplete, lets add the missing strings. Change-Id: If9e80b4bd8bdc31323c7c276155b2538e20a99be Related: OS#2978 --- M src/coding/gsm0503_amr_dtx.c M tests/dtx/dtx_gsm0503_test.ok 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/coding/gsm0503_amr_dtx.c b/src/coding/gsm0503_amr_dtx.c index 724cf09..7069b96 100644 --- a/src/coding/gsm0503_amr_dtx.c +++ b/src/coding/gsm0503_amr_dtx.c @@ -45,16 +45,18 @@ static const ubit_t codec_mode_4_sid[] = { 0, 0, 1, 0, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 1, 1 }; const struct value_string gsm0503_amr_dtx_frame_names[] = { + { AMR_OTHER, "AMR_OTHER (audio)" }, { AFS_SID_FIRST, "AFS_SID_FIRST" }, - { AFS_SID_UPDATE, "AFS_SID_UPDATE" }, + { AFS_SID_UPDATE, "AFS_SID_UPDATE (marker)" }, + { AFS_SID_UPDATE_CN, "AFS_SID_UPDATE_CN (audio)" }, { AFS_ONSET, "AFS_ONSET" }, - { AHS_SID_UPDATE, "AHS_SID_UPDATE" }, + { AHS_SID_UPDATE, "AHS_SID_UPDATE (marker)" }, + { AHS_SID_UPDATE_CN, "AHS_SID_UPDATE_CN (audio)" }, { AHS_SID_FIRST_P1, "AHS_SID_FIRST_P1" }, { AHS_SID_FIRST_P2, "AHS_SID_FIRST_P2" }, { AHS_ONSET, "AHS_ONSET" }, { AHS_SID_FIRST_INH, "AHS_SID_FIRST_INH" }, { AHS_SID_UPDATE_INH, "AHS_SID_UPDATE_INH" }, - { AMR_OTHER, "NON DTX FRAME (OTHER)" }, { 0, NULL } }; diff --git a/tests/dtx/dtx_gsm0503_test.ok b/tests/dtx/dtx_gsm0503_test.ok index a95a18b..77a4936 100644 --- a/tests/dtx/dtx_gsm0503_test.ok +++ b/tests/dtx/dtx_gsm0503_test.ok @@ -1,9 +1,9 @@ FR AMR DTX FRAMES: ==> AFS_SID_FIRST, n_errors=0, n_bits_total=212 - ==> AFS_SID_UPDATE, n_errors=0, n_bits_total=212 + ==> AFS_SID_UPDATE (marker), n_errors=0, n_bits_total=212 ==> AFS_ONSET, n_errors=0, n_bits_total=228 HR AMR DTX FRAMES: - ==> AHS_SID_UPDATE, n_errors=0, n_bits_total=212 + ==> AHS_SID_UPDATE (marker), n_errors=0, n_bits_total=212 ==> AHS_SID_FIRST_P1, n_errors=0, n_bits_total=212 ==> AHS_SID_FIRST_P2, n_errors=0, n_bits_total=114 ==> AHS_ONSET, n_errors=0, n_bits_total=114 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9e80b4bd8bdc31323c7c276155b2538e20a99be Gerrit-Change-Number: 17931 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-MessageType: merged