neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 )
Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() ...................................................................... Patch Set 1: Requiring a ta argument can be a good way to make sure callers never forget to set the ta. For sched_ul_ass_or_rej(), can there ever be a situation where ta was forgotten to set in the ms? IIUC this isn't a functional change. API design wise I tend to prefer the "safer" API that ensures ta is never omitted...? I'm not sure why you spent time to write this patch, but to not drag out a bikeshed: if you insist that this must happen, and if you are certain that ta is never forgotten, consider this a +1 from me. If you're unsure then why not just leave this API as it is... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iebb9c57f458690e045ddc45c800209ad8cf621e0 Gerrit-Change-Number: 18224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 13 May 2020 12:42:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
