fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 )
Change subject: pcu: use correct RA type to properly test 2phase access ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/2/library/RLCMAC_Templates.ttcn File library/RLCMAC_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/2/library/RLCMAC_Templates.ttcn@439 PS2, Line 439: tr_RLCMAC_UL_PACKET_ASS You could do it without code duplication by extending (inheriting) this template using 'extends' keyword. Alternatively, you could join both ul_assignment.gprs and ul_assignment.egprs into a union, and accept a template parameter here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If636a4898dfa175fdbd6baf04f7f2c955a9c525d Gerrit-Change-Number: 18239 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 13 May 2020 18:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
