laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18272 )
Change subject: contrib: integrate RPM spec ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18272/1/contrib/libosmocore.spec File contrib/libosmocore.spec: https://gerrit.osmocom.org/c/libosmocore/+/18272/1/contrib/libosmocore.spec@16 PS1, Line 16: Ve the usual method that I knew even 20 years ago was to address this is to have a spec.in file in the source tree and have autotools generate the .spec file from spec.in while substituting PACKAGE_VERSION (or whatever the autoconf variable name is). Unless this is currently no longer considered good practice, I suggest to implement it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I59255889740195ec811a947a7130ae0918ea4b4d Gerrit-Change-Number: 18272 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roox <mar...@gmx.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 16 May 2020 19:59:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
