Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18262 )
Change subject: trx_toolkit/transceiver.py: add frequency hopping support ...................................................................... Patch Set 2: > Patch Set 2: > > I still think moving the freq list to be separated by command would allow you > to drop that "variable" arg part. I don't see much benefit from that, sorry. Right now the CTRLInterface splits a command into a list for us, while with comma we would have to do that ourselves in the 'SETFH' handling code. I could do it that way, but none of the existing commands using comma to separate arguments, so let's make the new (not really new, but still) command consistent. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I587e4f5da67c7b7f28e010ed46b24622c31a3fdd Gerrit-Change-Number: 18262 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 17 May 2020 07:44:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
