Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258 )
Change subject: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258/2/pcu/PCU_Tests.ttcn@86 PS2, Line 86: cv_countdown > This value of cv_countdown, if meaning the same as BS_CV_MAX, is wrong, > because 15 always means "mor […] Yep, it looks wrong, but my point is that this is a value that we send to the IUT, while in the test suite we use another different value. Ideally we should have a default value in 'modulepar' section and use it everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I685d1535154197bb85e18875e0a4d41122a24fa0 Gerrit-Change-Number: 18258 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 17 May 2020 07:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-MessageType: comment
