Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 )
Change subject: Move all GPRS helper function to its own file and component ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@66 PS2, Line 66: BTS.send(ts_RAW_PCU_CMD(GENERAL_CMD_SHUTDOWN)); > Wait, where is this line? I just had a conversation with Pau, so he explained that this line is not here because component 'GPRS_MS_CT' has no access to vc_BTS. We could substitute it by f_sleep(0.3), but it does not look like a good solution to me. In the end, we decided to move the BTS component here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@168 PS2, Line 168: f_pcuif_rx_imm_ass Basically all functions where you removed 'private' qualifier should be revisited. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieae27d6e707f79ec2145864ef5cd67ddbbec9314 Gerrit-Change-Number: 18333 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sun, 17 May 2020 18:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <[email protected]> Gerrit-MessageType: comment
