osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18351 )
Change subject: Get rid of class GprsCodingScheme ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM, could not find any logical changes. I've read through the changes and compared gprs_coding_scheme.cpp with coding_scheme.c side by side. https://gerrit.osmocom.org/c/osmo-pcu/+/18351/1/src/coding_scheme.c File src/coding_scheme.c: https://gerrit.osmocom.org/c/osmo-pcu/+/18351/1/src/coding_scheme.c@228 PS1, Line 228: return mcs_info[cs].downlink.ext_bits; Cosmetic: missing indent https://gerrit.osmocom.org/c/osmo-pcu/+/18351/1/src/coding_scheme.c@308 PS1, Line 308: needStuffing Cosmetic: make this snake case? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie9ce2144ba9e8dbba9704d4e0000a2929e3e41df Gerrit-Change-Number: 18351 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 07:19:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
