laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18438 )
Change subject: Return -ENOTCONN from gsm0408_rcvmsg() if SCCP link is already closed. ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > I'm happy with returning an error here, but the problem is that > > abis_rsl_rx_rll() propagates that error to libosmo-abis. It shouldn't. > > Actually, I think we just should return 0 here instead of an error. works for me. > Whether to forward the message or not to an SCCP connection is an internal > question for the GSM 04.07 code, I would say. And thus should stay within > gsm0408_rcvmsg(). ack. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2d430ebc894a2345bebaa1841a75e94a3b45eae2 Gerrit-Change-Number: 18438 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2020 09:01:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
