pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18504 )
Change subject: create only one SCCP user per SCCP instance ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18504/3/src/osmo-bsc/osmo_bsc_sigtran.c File src/osmo-bsc/osmo_bsc_sigtran.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18504/3/src/osmo-bsc/osmo_bsc_sigtran.c@550 PS3, Line 550: /* Bind SCCP user. Bind only one user per sccp_instance. */ > I'm implementing MSC pooling, i.e. there are multiple A links to MSCs. […] ACK thanks. Please also make sure that there's no use-after-free if for whatever reason the "msc X" is dropped and is freed (and perhaps freeing msc->a.sccp_user?). Not saying it will happen simply to make sure this kind of stuff is fine :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6a2710edeb9ba047ae70e6b49d4c2e5f06d41a4e Gerrit-Change-Number: 18504 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2020 20:46:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
