pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18694 )
Change subject: gsm0808: fix endieness of call identifier ...................................................................... Patch Set 1: Is the integer expected to be sent in network byte order or host byte order? If network byte order is expected, I would expect the function to receive a host-byte-order integer and hence htonl() is needed. Which means the bug is probably somewhere else? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Gerrit-Change-Number: 18694 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2020 16:19:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
