laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18649 )
Change subject: Add support for ADF_USIM/EF_EHPLMN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py@82 PS1, Line 82: (res, sw) = self._scc.read_binary(EF_USIM_ADF_map['EHPLMN']) > is it ok to put this USIM specific things in the generic Card class? […] yes, I prefer your approach with an USIM card type. Would you have time to submit that as a follow-up patch? We'd probably have to do the same with ISIM. And yes, you can add other functions here, even if they're not used [yet] by pySim-read. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22d96ab4a424ec5bc1fb02f5e80165c646a748d3 Gerrit-Change-Number: 18649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: gui...@gmail.com <gui...@gmail.com> Gerrit-Comment-Date: Sun, 07 Jun 2020 19:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: gui...@gmail.com <gui...@gmail.com> Gerrit-MessageType: comment
