laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18586 )
Change subject: Implement TRXC cmd NOMTXPOWER ...................................................................... Patch Set 1: Code-Review+1 we actually do have the real measured values for USRP Bxxx so they could be used right away. Also, it is obvious that we need infrastructure to return not some single magic value that is stated in each class, but that each class will need some support infrastructure to have a per-device (not per-driver, but per-sdr-device/model) value, and that this value will also have to be per-band. No point in having each class/driver reinvent that, so maybe some shared infrastructure? Also, it is equally known that this value must be possible to override from the VTY. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1d7efe56e008d8d60e23f9a85aa40809f7f84d9c Gerrit-Change-Number: 18586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Reviewer: roh <jstei...@sysmocom.de> Gerrit-Comment-Date: Sun, 07 Jun 2020 19:12:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
