laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/18730 )
Change subject: e1_input: refcount inc line during e1_sign_link_create, not
during line update
......................................................................
e1_input: refcount inc line during e1_sign_link_create, not during line update
Increase reference count when a new sign_link using the line is created.
Otherwise the line is freed too quickly during e1inp_sign_link_destroy()
with several TRX being used, since each RSL link is missing a reference.
That extra refcoutny in update() is not really needed given that we already
have a link assigned on the line when we call update.
Fixes: OS#3612
Fixes: OS#4094
Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013
---
M src/e1_input.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/e1_input.c b/src/e1_input.c
index 7066acf..9ea4f17 100644
--- a/src/e1_input.c
+++ b/src/e1_input.c
@@ -586,6 +586,8 @@
link->tei = tei;
link->sapi = sapi;
+ e1inp_line_get(link->ts->line);
+
llist_add_tail(&link->list, &ts->sign.sign_links);
return link;
@@ -855,8 +857,6 @@
struct input_signal_data isd;
int i, rc;
- e1inp_line_get(line);
-
if (line->driver && line->ops && line->driver->line_update) {
rc = line->driver->line_update(line);
} else
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18730
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013
Gerrit-Change-Number: 18730
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged
