pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/18706 )
Change subject: NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using
UDP/IP
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c
File src/gb/gprs_ns_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c@517
PS2, Line 517: vty_nsi->nsip.use_reset_block_unblock = true;
> that returns a positive/negative integer, I prefer to keep it explicit. […]
Ok, but << !strcmp(argv[0], "enabled") >> doesn't return a negative/positive
integer, since you are applying a boolean operator, it will return either 0 or
(NOT 0), which is going to be 1, so one can assume false/true values.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18706
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
Gerrit-Change-Number: 18706
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 09:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment
