pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 )
Change subject: endp: add name generator function for E1 endpoints ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG@10 PS1, Line 10: correct. Lets add an endpoint name generator function that derives a Let's https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c@87 PS1, Line 87: gen_e1_epname(ep_name_buf, trunk->trunk_nr, index / 14, index % 14); So you'll be in the end crafting an index value to pass it to mgcp_endp_alloc(), to then uncraft it to convert it into a string. Does that really make sense? If IDs are really strings, then simply pass a string to mgcp_endp_alloc? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I70e0c3f96aa3947165f9926666815ee5614c8f57 Gerrit-Change-Number: 18745 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2020 14:40:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
