daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18720 )
Change subject: Count assignment rates per BTS as well ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h@1441 PS2, Line 1441: [BTS_CTR_CHREQ_SUCCESSFUL] = {"chreq:successful", "Successful channel requests (immediate assign sent)."}, > That's for the previous patch, not for this one, right? You're right, moved it (and removed the period) https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h@1487 PS2, Line 1487: [BTS_CTR_ASSIGNMENT_ATTEMPTED] = {"assignment:attempted", "Assignment attempts."}, > Remove dot at the end Ok, I have also added a separate commit to remove the period in other counter descriptions. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a Gerrit-Change-Number: 18720 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2020 15:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
