pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/18747 )

Change subject: firmware/apps/rssi: enlarge text buffer in refresh_display()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c
File src/target/firmware/apps/rssi/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c@197
PS1, Line 197:          sprintf(text, "%c%cE%c%c", (power >= 40) ? 'D':'G',
Would be great using snprintf too.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18747
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
Gerrit-Change-Number: 18747
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 15:52:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to