fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18773 )
Change subject: gsm_data_shared: use bitvec API to allocate the feature vector ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18773/1/src/common/gsm_data_shared.c File src/common/gsm_data_shared.c: https://gerrit.osmocom.org/c/osmo-bts/+/18773/1/src/common/gsm_data_shared.c@325 PS1, Line 325: bts->features = bitvec_alloc(MAX_BTS_FEATURES / 8, bts); > (should this also be OSMO_BYTES_FOR_BITS()?) I don't think it's necessary given that this macro is defined in libosmocore, and divided by 8 without remainder. We can change this later. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19ecfc619c0dc2bfd14f054d17e222c4e16f6238 Gerrit-Change-Number: 18773 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jun 2020 17:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
