pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789 )

Change subject: epc: add method to call process on EPC in a non-blocking fashion
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789/1/src/osmo_gsm_tester/obj/epc.py
File src/osmo_gsm_tester/obj/epc.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789/1/src/osmo_gsm_tester/obj/epc.py@79
PS1, Line 79:     def run_wait(self, name, popen_args, sync=True):
Better simply return the proc object to the test and use whatever you want 
there.
Feel free to rename it to "prepare_process" or alike.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18789
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ia6372e55a8829f722e40db537d9dfd63a94d1be9
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <an...@softwareradiosystems.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 12 Jun 2020 13:13:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to