neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 )
Change subject: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn File library/RSL_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn@551 PS1, Line 551: if (ispresent(ConnectionTable[i].comp_ref) and ConnectionTable[i].comp_ref != null) { > Is this ispresent() really needed? I think they may have been an error here > and the same thing you a […] I was also thinking about this aspect and decided that simply checking both is safest and least effort to fix the problem ATM. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5 Gerrit-Change-Number: 18761 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 12 Jun 2020 13:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
