neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18721 )
Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp@1044 PS2, Line 1044: << " dB based on GSM band information"; patch 18723 is removing this logging again, maybe not add it at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb Gerrit-Change-Number: 18721 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Reviewer: roh <jstei...@sysmocom.de> Gerrit-Reviewer: tnt <t...@246tnt.com> Gerrit-Comment-Date: Sun, 14 Jun 2020 11:56:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment